Unless I missed something, it's not shortening his lifespan or anything, it's just not lengthening his lifespan either. Most garden cultivation methods lengthen one's lifespan (iirc one guy was said to have lived over 300 years). MC said his method "does no good to one's age" and seems to be incompatible with normal cultivation methods so they would have relatively short lifespans.