In the words of the irrefutable Gayle: Do not surprise someone with a life decision. I think 'asking' in this way, before he has the ring, is really very sweet. If she had (somehow) seemed unsure, then he'd know not to try and put her on the spot in public with an actual ring, and to wait a while.
Anyways these two are dorks, but i love them dearly.