[Fixed] [Mainsite] Popular New Titles buttons not working

[fuzzyk]

On the mainsite, the buttons for navigating the "Popular New Titles" carousel are no longer working. I guess the April 1st update contained the relevant change, but I’m not entirely certain.

The buttons appears to behave correctly except that nothing happens when clicking them. No errors in console either.

I have this behavior on both desktop (Firefox on Windows, uBlock Origin) and mobile (Safari on iPad, Adguard). However, it works in other browsers (Edge, Chrome, Firefox Developer Edition, all without extensions).

I believe ad-blockers are to blame, but I’m not sure how that could be; uBlock Origin in its default config only blocks googletagmanager.com and googlesyndication.com plus some parts of Recaptcha, none of which should be related.

 

[kouyo]

Hi, I can confirm this bug is specifically caused by a conflict with uBlock Origin. Since the issue only occurs when ad-blocker is turned on, this is not an issue on our site's code, please report this to the uBlock Origin developers for a fix.

 

[kouyo]

After a second look, I’ve ruled out the ad-blocker as the cause.
The issue appears to be intermittent, making it difficult to pinpoint the exact trigger.

I remember a similar bug (if not the same) from last year's april fools, but it was deemed as "wont fix" due to the short nature of the april fool's event.

 

[Angry_Panda]

It appears to 'lock' the button navigation on a fresh load of the home page, but if I navigate to another page (using the left hand menu) and then back to the home page (in such a way where the left menu doesn't reload, based on the AF ad at bottom remaining the same), the buttons work again.

 

[fuzzyk]

I just encountered another variant of the bug, where even the automatic switching stalled. In this case, the "No." next to the buttons changed to "NaN", so maybe some initial state corruption? Possibly with a race condition?

 

[Angry_Panda]

Possibly with a race condition?

This is what I was thinking, as it appears one title briefly flashes in the display position before bring replaced with another when this bug occurs.

 

[kouyo]

I just encountered another variant of the bug, where even the automatic switching stalled. In this case, the "No." next to the buttons changed to "NaN", so maybe some initial state corruption? Possibly with a race condition?

Hi, thanks for the update. The "NaN" error definitely confirm this is the same issue I've mentioned before. We'll be tracking this internally.

 

[fuzzyk]

It appears the April Fools stuff is now gone. Just for the record, the error is still there.

Also, to clarify: The NaN stuff doesn't always trigger. Often, the carousel is still auto-playing as it should. Swiping also still works. It's just the buttons that do not work.

 

[Elaborate]

I also have this problem. I use firefox on two different computers, both with UBlock, but to be thorough, today I tried with MS Edge which I never usually use, and had the same issue (except there the number also showed as "NO.NAN").

Some days the buttons work, some days they don't.
I note that the button-click event calls the Date.now() function, which seems like an excellent place to start looking for a date-dependent error.

 

[Elaborate]

Looking at it when it's working compared to not working, when it works there are two events tied to the next button.
The second one:

function c(g) {
  g.preventDefault(),
  !(t.isEnd && !t.params.loop && !t.params.rewind) &&
    (t.slideNext(), a("navigationNext"))
}

seems to be the actual next function.

When it doesn't work, that event is absent.

 

[rphilly]

I'm also seeing this issue starting beginning of last week on Chrome. The carousel auto-advances but the buttons to move through the slides don't work.

 

[Bartolumiu]

Hi there
The latest deploy to both Canary and prod seems to have fixed the issue (couldn't reproduce it anymore in multiple environments).
I'll keep this thread unlocked for the next couple of hours, so if anyone can still reproduce the issue, please let us know.